Skip to content

Export __call_view__ in C##3691

Merged
joshua-spacetime merged 29 commits into
masterfrom
rekhoff/csharp_replication_test_with_views
Nov 20, 2025
Merged

Export __call_view__ in C##3691
joshua-spacetime merged 29 commits into
masterfrom
rekhoff/csharp_replication_test_with_views

Conversation

@rekhoff

@rekhoff rekhoff commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Description of Changes

  1. Updates the Replication Tests in sdks/csharp/examples~/regression-tests to include better coverage of Views
  2. Added missing linkage for call_view and call_view_anon
  3. Updated *ViewDispatcher Invoke to transform BSATN.ValueOption<> into BSATN.List<>
  4. Fixed issues with the indexing of views to match correctly during call_view and call_view_anon

API and ABI breaking changes

No

Expected complexity level and risk

2

Testing

  • Running run-regression-tests.sh passes.

@rekhoff rekhoff changed the base branch from master to jlarabie/csharp-view-ns November 18, 2025 22:15
@rekhoff rekhoff self-assigned this Nov 19, 2025
Comment thread sdks/csharp/examples~/regression-tests/client/Program.cs Outdated
Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
Signed-off-by: rekhoff <r.ekhoff@clockworklabs.io>
Comment thread sdks/csharp/examples~/regression-tests/client/Program.cs
@rekhoff rekhoff marked this pull request as ready for review November 19, 2025 17:43
@joshua-spacetime joshua-spacetime changed the base branch from jlarabie/csharp-view-ns to master November 20, 2025 00:00
Comment thread crates/bindings-csharp/Codegen/Module.cs Outdated
Comment thread crates/bindings-csharp/Codegen/Module.cs Outdated
Comment thread crates/bindings-csharp/Codegen/Module.cs
Comment thread sdks/csharp/examples~/regression-tests/client/Program.cs
Comment thread sdks/csharp/examples~/regression-tests/client/Program.cs Outdated
…iewDispatchers to make sure the indexes align
Comment thread crates/bindings-csharp/Codegen/Module.cs
Comment thread crates/bindings-csharp/Codegen/Module.cs
JasonAtClockwork and others added 3 commits November 20, 2025 07:30
Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
Signed-off-by: Jason Larabie <jason@clockworklabs.io>
Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
Signed-off-by: Jason Larabie <jason@clockworklabs.io>
@joshua-spacetime joshua-spacetime changed the title Improves replication tests with Views in C# Export __call_view__ in C# Nov 20, 2025
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Nov 20, 2025
Merged via the queue into master with commit cb35104 Nov 20, 2025
27 checks passed
mamcx pushed a commit that referenced this pull request Nov 20, 2025
# Description of Changes

1. Updates the Replication Tests in
`sdks/csharp/examples~/regression-tests` to include better coverage of
Views
2. Added missing linkage for __call_view__ and __call_view_anon__
3. Updated *ViewDispatcher Invoke to transform BSATN.ValueOption<> into
BSATN.List<>
4. Fixed issues with the indexing of views to match correctly during
__call_view__ and __call_view_anon__

# API and ABI breaking changes

No

# Expected complexity level and risk

2

# Testing

- [x] Running `run-regression-tests.sh` passes.

---------

Signed-off-by: rekhoff <r.ekhoff@clockworklabs.io>
Signed-off-by: Jason Larabie <jason@clockworklabs.io>
Co-authored-by: Jason Larabie <jason@clockworklabs.io>
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
@bfops bfops deleted the rekhoff/csharp_replication_test_with_views branch May 7, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants